maintainer-feedback requested: [Bug 255093] audio/pulseaudio: optionalize X11

[b***@freebsd.org]

Bugzilla Automation <***@FreeBSD.org> has asked freebsd-desktop (Team)
<***@FreeBSD.org> for maintainer-feedback:
Bug 255093: audio/pulseaudio: optionalize X11
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255093



--- Description ---
Make audio/pulseaudio dependency on X11 optional.

Pulseaudio is needed to build www/firefox pulse-rust backend, which can be used
with pipewire-pulse instead of pulseaudio.

I run locally-patched ports tree that ensures that I am not building *any*
X11-related dependencies (e.g. even libGL and libx{11,xcb}), and building X11
just for the build time dependency breaks my X11-less setup.

This might also be desirable for headless environments, e.g. servers using
pulseaudio for some reason. I wouldn't mind if this will never be merged.

Consolekit has a hard dependency on X11 by using checks in configure files and
including and then using Xlib.h, so don't depend on this lib if X11 is off.

No functional change for the default build.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255093

--- Comment #1 from Evgeniy Khramtsov <***@khramtsov.org> ---
(In reply to Evgeniy Khramtsov from comment #0)

Post by b***@freebsd.org
so don't depend on this lib if X11 is off

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252783#c2

If this gets committed, the "libck-connector.so:sysutils/consolekit2" part of
this patch can be removed.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255093

--- Comment #2 from Evgeniy Khramtsov <***@khramtsov.org> ---
Actual/rebased version is available now here:
https://codeberg.org/ei/ports/commits/branch/ei

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255093

--- Comment #3 from commit-***@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=9f6ccfbfaf7b949f339cc2ff31155218fcfce9eb

commit 9f6ccfbfaf7b949f339cc2ff31155218fcfce9eb
Author: Evgeniy Khramtsov <***@khramtsov.org>
AuthorDate: 2021-06-04 19:55:00 +0000
Commit: Gleb Popov <***@FreeBSD.org>
CommitDate: 2021-06-04 20:01:38 +0000

audio/pulseaudio: Add X11 option.

PR: 255093
Tested by: arrowd

audio/pulseaudio/Makefile | 10 ++++++----
audio/pulseaudio/pkg-plist | 18 +++++++++---------
2 files changed, 15 insertions(+), 13 deletions(-)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255093

Gleb Popov <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|New |Closed
Resolution|--- |FIXED
CC| |***@FreeBSD.org

--- Comment #4 from Gleb Popov <***@FreeBSD.org> ---
Pushed in, thanks!