[Bug 256336] textproc/py-gi-docgen: hard-coded /usr/local

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336

Bug ID: 256336
Summary: textproc/py-gi-docgen: hard-coded /usr/local
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: ***@FreeBSD.org
Reporter: ***@liamekaens.com
Flags: maintainer-feedback?(***@FreeBSD.org)
Assignee: ***@FreeBSD.org

If LOCALBASE is not /usr/local, the pango build fails because
textproc/py-gi-docgen has a hard-coded reference to /usr/local.

===============
.
.
FAILED: docs/Pango
/usr/loc/bin/gi-docgen generate --quiet
--add-include-path=/wrkdirs/usr/ports/x11-toolkits/pango/work/pango-1.48.4/_build/docs/../pango
--config docs/pango.toml --output-dir=docs/Pango --no-namespace-dir
--content-dir=/wrkdirs/usr/ports/x11-toolkits/pango/work/pango-1.48.4/docs
pango/Pango-1.0.gir
ERROR: Could not find GIR dependency in the search paths: GObject-2.0
.
.
===============

[b***@freebsd.org]

Bugzilla Automation <***@FreeBSD.org> has asked freebsd-desktop (Team)
<***@FreeBSD.org> for maintainer-feedback:
Bug 256336: textproc/py-gi-docgen: hard-coded /usr/local
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336



--- Description ---
If LOCALBASE is not /usr/local, the pango build fails because
textproc/py-gi-docgen has a hard-coded reference to /usr/local.

===============
.
.
FAILED: docs/Pango
/usr/loc/bin/gi-docgen generate --quiet
--add-include-path=/wrkdirs/usr/ports/x11-toolkits/pango/work/pango-1.48.4/_bui
ld/docs/../pango
--config docs/pango.toml --output-dir=docs/Pango --no-namespace-dir
--content-dir=/wrkdirs/usr/ports/x11-toolkits/pango/work/pango-1.48.4/docs
pango/Pango-1.0.gir
ERROR: Could not find GIR dependency in the search paths: GObject-2.0
.
.
===============

[b***@freebsd.org]

John Hein <***@liamekaens.com> has asked freebsd-desktop (Team)
<***@FreeBSD.org> for maintainer-approval:
Bug 256336: textproc/py-gi-docgen: hard-coded /usr/local
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336

Attachment 225453: [patch] fix hard-coded /usr/local
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225453&action=edit



--- Comment #1 from John Hein <***@liamekaens.com> ---
Created attachment 225453
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225453&action=edit
[patch] fix hard-coded /usr/local

Don't hard code the default search path with "/usr/local" - use LOCALBASE.

This patch bumps PORTREVISION. This patch will not change the default packages
where LOCALBASE = /usr/local, so that bump is at the committer's discretion. I
suggest it should be bumped - if someone has already installed a py-gi-docgen,
but is failing the pango build because of a non-default LOCALBASE, it would
help to bump PORTREVISION. In other words, this change does not directly fix a
build error with the py-gi-docgen port, but rather a separate port that depends
on py-gi-docgen. So bumping PORTREVISION is a good idea.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336

John Hein <***@liamekaens.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org
Attachment #225453| |maintainer-approval?(deskto
Flags| |***@FreeBSD.org)

--- Comment #1 from John Hein <***@liamekaens.com> ---
Created attachment 225453
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225453&action=edit
[patch] fix hard-coded /usr/local

Don't hard code the default search path with "/usr/local" - use LOCALBASE.

This patch bumps PORTREVISION. This patch will not change the default packages
where LOCALBASE = /usr/local, so that bump is at the committer's discretion. I
suggest it should be bumped - if someone has already installed a py-gi-docgen,
but is failing the pango build because of a non-default LOCALBASE, it would
help to bump PORTREVISION. In other words, this change does not directly fix a
build error with the py-gi-docgen port, but rather a separate port that depends
on py-gi-docgen. So bumping PORTREVISION is a good idea.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336

--- Comment #2 from John Hein <***@liamekaens.com> ---
QA:
poudriere testport (textproc/py-gi-docgen, x11-toolkits/pango) - ok
(stable/11 amd64)
portlint - ok

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256336

John Hein <***@liamekaens.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |easy, patch