maintainer-feedback requested: [Bug 256078] textproc/libxml2: Update to 2.9.12 - WIP

[b***@freebsd.org]

Bugzilla Automation <***@FreeBSD.org> has asked freebsd-desktop (Team)
<***@FreeBSD.org> for maintainer-feedback:
Bug 256078: textproc/libxml2: Update to 2.9.12 - WIP
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256078



--- Description ---
Hi,

I've been hacking on libxml2 a bit including converting it to CMake and would
like some input, there are some differences between current version and the new
version that I'm not sure about on how to handle.

./work/stage/usr/local/lib/xml2Conf.sh
-- CMAKE --
prefix is expanded
XML2_LIBS="-lxml2 -lz -llzma -pthread -lm"

-- Autotools --
XML2_LIBS="-lxml2 -lz -L/usr/lib -llzma -L/usr/lib -lm"


./work/stage/usr/local/libdata/pkgconfig/libxml-2.0.pc
-- CMAKE --
Libs.private: -pthread -lz -llzma -lm

-- Autotools --
Libs.private: -lz -L/usr/lib -llzma -L/usr/lib -lm


Questions:
Is -L/usr/lib needed? From what I can tell CMake doesn't have a variable for
this, suggestions are welcome. In worst case we can hardcode it.

Current version in ports forces -DPIC cflag, is this needed?
https://cgit.freebsd.org/ports/tree/textproc/libxml2/files/patch-Makefile.in

make test passes on 13-STABLE (amd64)

Motivation for moving to CMake is mainly because it's faster and much easier to
debug, I do plan to upstream as many changes as possible but perhaps it's
futile effort?

I'm not sure how to handle py-libxml2 in a sane way. :/

Note for users:
https://gitlab.gnome.org/GNOME/libxslt/-/issues/51
https://git.alpinelinux.org/aports/diff/main/libxslt/APKBUILD?id=3ec3aafa689b13
4df3f999baf8841099c6e8c422

Changes for 2.9.12
https://gitlab.gnome.org/GNOME/libxml2/-/commit/b48e77cf4f6fa0792c5f4b639707a2b
0675e461b

Thanks in advance,
Daniel

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256078

Tobias C. Berner <***@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags|maintainer-feedback?(deskto |maintainer-feedback+
|***@FreeBSD.org) |
CC| |***@freebsd.org

--- Comment #1 from Tobias C. Berner <***@freebsd.org> ---
Moin moin

I think it is generally a good idea to move the ports to use a more modern
build system.


Also the -L/usr/lib should be there by default anyways, so, no loss there.


What's the issue you're having with the python variant?


mfg Tobias

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256078

--- Comment #2 from Daniel Engberg <***@pyret.net> ---
Hi,

Thanks for the reply! I'll drop that and ${CMAKE_INSTALL_OLDINCLUDEDIR}.

The issue with the python port is that it currently works as it's own project (
https://github.com/freebsd/freebsd-ports/blob/main/textproc/py-libxml2/Makefile#L10
) unless I've misunderstood how it works. This approach isn't possible with at
least the current upstream version of CMakeLists.txt and I'm not sure how to
handle it properly being a python port.

Best regards,
Daniel

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256078

Daniel Engberg <***@pyret.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225170|0 |1
is obsolete| |

--- Comment #3 from Daniel Engberg <***@pyret.net> ---
Created attachment 225208
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225208&action=edit
Patch for libxml2 (WIP) v2

Clean up Makefile a bit more, remove CMAKE_INSTALL_OLDINCLUDEDIR
Still not sure how to handle py-libxml2
There are a few patches left that wont be needed depending on how we end up
doing python port.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256078

Daniel Engberg <***@pyret.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |Overcome By Events
Status|New |Closed

--- Comment #4 from Daniel Engberg <***@pyret.net> ---
I don't have time/ability to hack on this within a reasonable timeframe so just
stick to autotools for now.